[Crash-utility] [PATCH v3] Show module taint flags

Aaron Tomlin atomlin at redhat.com
Tue May 7 17:47:57 UTC 2013


Hi Dave,


Sorry about the delay. I've finally found the time to attempt another version.

As per your request, I've updated *help_mod[] to document the -T option.
Also in this particular version, I omit ' ' and '-', when false, as I'm under 
the impression that we're only interested in true values as per module_flags()
(since 2.6.25).
I suspect that there shouldn't be a situation where a module isn't tainted since
every module is either proprietary license or GPL. However, if this is not 
acceptable I can change this behaviour. 

For module.gpgsig_ok case (as seen in kernel-2.6.32-1.el6), I've decided to follow
the same logic to highlight "(U)" to the user, as per print_modules().
With regards to module.sig_ok, this is handled, as seen under 3.8.9-200.fc18:

	nf_nat                   G 
	bnx2i                    G 
	ip6t_REJECT              G 
	nf_defrag_ipv6           G 
	be2iscsi                 G 
	tun                      G 
	test                     GFO
	
For pre 2.6.28 kernels, I'll work on a solution that simply displays the bit number
to then refer the user to the relevant kernel source for details on what the bit
number means, as per your suggestion. I just wanted to get this version out to the
mailing list for review.

Cheers,
Aaron

--8<--

 help.c   |   18 ++++++++-
 kernel.c |  124 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 140 insertions(+), 2 deletion

-------------- next part --------------
A non-text attachment was scrubbed...
Name: show-mod-taint-flags-v3.patch
Type: text/x-patch
Size: 6122 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20130507/b8afc855/attachment.bin>


More information about the Crash-utility mailing list