[Crash-utility] [PATCH v3] makedumpfile: fix max_mapnr issue on system has over 44-bit addressing

HATAYAMA Daisuke d.hatayama at jp.fujitsu.com
Tue Oct 15 07:32:59 UTC 2013


(2013/10/15 14:58), HATAYAMA Daisuke wrote:
> (2013/10/14 21:16), Jingbai Ma wrote:
> <cut>

>> @@ -2793,7 +2806,7 @@ initialize_bitmap_memory(void)
>>       bmp->offset = bitmap_offset + bitmap_len / 2;
>>       info->bitmap_memory = bmp;
>>
>> -    max_sect_len = divideup(dh->max_mapnr, BITMAP_SECT_LEN);
>> +    max_sect_len = divideup(kh->max_mapnr_64, BITMAP_SECT_LEN);
>>       info->valid_pages = calloc(sizeof(ulong), max_sect_len);
>
> Ah, please here needs to be fixed, too. Here should have been
> used sizeof(int) but now sizeof(off_t) should be used.
>

This is wrong. Please ignore.

-- 
Thanks.
HATAYAMA, Daisuke




More information about the Crash-utility mailing list