[Crash-utility] [PATCH 0/11] Implement percpu handling for crash

Dave Anderson anderson at redhat.com
Mon Oct 21 15:35:36 UTC 2013



----- Original Message -----
> Hi Dave et al.
> 
> thanks to the feedback, I have reworked my patch set. It is now much
> larger than the first version, but I'm also much more happy with it.
> 
> I'm pretty sure that there are still some issues here and there, so
> as always, your comments are most welcome.
> 
> Petr Tesarik

Hi Petr,

I plan to get to this patch-set this afternoon, but I when I apply
them to an unmodified crash-7.0.2 tree, I get a few errors:

[1/11] p-filter-fn.patch
patching file symbols.c

[2/11] get_cpumask_buf.patch
patching file defs.h
patching file kernel.c
patching file tools.c

[3/11] percpu-p.patch
patching file symbols.c
patching file help.c

[4/11] typename-errors.patch
patching file symbols.c

[5/11] cpumask-all.patch
patching file tools.c
patching file help.c
Hunk #1 FAILED at 1089.
Hunk #2 succeeded at 2855 (offset 3 lines).
1 out of 2 hunks FAILED -- saving rejects to file help.c.rej

[6/11] datatype-flags.patch
patching file symbols.c

[7/11] datatype-cleanup.patch
patching file symbols.c

[8/11] datatype-member-offset.patch
patching file symbols.c

[9/11] datatype-offsets.patch
patching file symbols.c
Hunk #1 succeeded at 5872 (offset 1 line).
Hunk #2 succeeded at 5906 (offset 1 line).
Hunk #3 succeeded at 5942 with fuzz 1 (offset -7 lines).

[10/11] datatype-make-fn.patch
patching file symbols.c
Hunk #3 FAILED at 5902.
1 out of 5 hunks FAILED -- saving rejects to file symbols.c.rej

[11/11] percpu-struct.patch
patching file help.c
Hunk #1 succeeded at 4106 (offset 2 lines).
Hunk #2 succeeded at 4141 (offset 2 lines).
Hunk #3 succeeded at 4401 (offset 2 lines).
Hunk #4 succeeded at 4437 (offset 2 lines).
patching file symbols.c
Hunk #6 FAILED at 5944.
Hunk #7 succeeded at 6876 with fuzz 2 (offset 921 lines).
1 out of 7 hunks FAILED -- saving rejects to file symbols.c.rej
 
I haven't investigated the failures above (which may be obvious), but can you 
maybe whip up a single patch against an unmodified crash-7.0.2 tree?

Thanks,
  Dave




More information about the Crash-utility mailing list