[Crash-utility] [PATCHv2 07/11] Cleanup handling of flags in cmd_datatype_common()
Petr Tesarik
ptesarik at suse.cz
Mon Oct 21 19:49:38 UTC 2013
This patch improves handling of struct/union flags:
1. You can now specify a typedef with "*". Previously it failed like
this:
crash> *acct_t ffff8800982ad520
*: invalid argument
2. Report an error if a non-structured type is used, instead of
giving no output, e.g.:
crash> *pid_t
*: invalid argument
3. Produce an error message if the type does not match the command:
crash> union page
union: data type mismatch: page is not a union
crash> struct thread_union
struct: data type mismatch: thread_union is not a struct
Additionaly, these checks are now performed early, that is before
entering the main printing loop.
Signed-off-by: Petr Tesarik <ptesarik at suse.cz>
---
symbols.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: datatype-cleanup.patch
Type: text/x-patch
Size: 2169 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20131021/d4db9897/attachment.bin>
More information about the Crash-utility
mailing list