[Crash-utility] [PATCH 0/2] Introduce bt -c
Dave Anderson
anderson at redhat.com
Mon Apr 28 14:58:43 UTC 2014
Hi Aaron,
Looks good -- queued for crash-7.0.7:
https://github.com/crash-utility/crash/commit/a91e4108669ec1ff7c3b4755c4e9f4ba6fc37735
Note that I made a couple minor changes -- similar to "bt -a", attempts to use -c on
a live system or with -g will be rejected, and I removed the "all" and "a" references in
the help page (even though they'd still work, they're redundant considering "bt -a").
Thanks,
Dave
----- Original Message -----
> Hi Dave,
>
> Thanks for the feedback.
>
> > That's a great idea -- but I'd prefer not to overload the -a option.
>
> Understood.
>
> > Since -c is available, can you use the already-available make_cpumask()
> > utility function to create a mask out of a comma or dash separated cpu
> > list? You can basically do the same thing as "irq -c" -- check out
> > "help irq" for the help page description, and cmd_irq() for a code
> > template.
>
> OK, here you go -- followed the logic in cmd_irq().
>
> Aaron Tomlin (2):
> Remove redundant count variable in cmd_bt
> Introduce bt -c
>
> help.c | 35 ++++++++++++++++++++++++++++++++++-
> kernel.c | 40 +++++++++++++++++++++++++++++++++++-----
> 2 files changed, 69 insertions(+), 6 deletions(-)
>
> --
> 1.9.0
>
>
More information about the Crash-utility
mailing list