[Crash-utility] [PATCH v2 0/4] some bugfixs for ARM

[Dave Anderson]

----- Original Message -----
> Hi Dave,
> 
> In this patch series, I introduce support for cpu_active_mask.
> And I use MAX(get_cpus_online(),get_cpus_active()) to get CPU
> number for ARM platform.
> 
> The last patch changes NR_CPUS to fit ARM linux's config.
> 
> Thanks,
> Liu Hua
> 
> changes from v1:
> -----------------------------------------------
>  -changed some macros related to cpu map
>  -use MAX(get_cpus_online(),get_cpus_active()) as online CPU
>   number

Hello Liu,

In order to prevent any possibility of API/ABI incompatibility
with currently-existing extension modules, I kept the old bit 
names in place along with your new "xxx_MAP" names, and I kept 
the NMI bit value unchanged (0x8), making your new ACTIVE_MAP 
bit equal to 0x10.  Accordingly, the cpu_flags-bit changes to
defs.h looks like this:

  #define POSSIBLE  (0x1)
  #define PRESENT   (0x2)
  #define ONLINE    (0x4)
  #define NMI       (0x8)
+ #define POSSIBLE_MAP (POSSIBLE)
+ #define PRESENT_MAP   (PRESENT)
+ #define ONLINE_MAP     (ONLINE)
+ #define ACTIVE_MAP       (0x10)

Other than that, the patch looks good -- queued for crash-7.0.7:

  https://github.com/crash-utility/crash/commit/8bff022b52abdf54f905f1b14f0ff5d36cad8d22

Thanks,
  Dave


> 
> Liu Hua (4):
>   crash: change some marcos related to cpu map
>   crash: support cpu_active_mask
>   crash: ARM: get online CPUs from cpu_active_mask
>   crash: ARM: change NR_CPUS to 32
> 
>  arm.c      |  2 +-
>  defs.h     | 12 +++++-----
>  diskdump.c |  4 ++--
>  kernel.c   | 76
>  ++++++++++++++++++++++++++++++++++++++++++++++++++++----------
>  netdump.c  |  4 ++--
>  ppc.c      |  2 +-
>  ppc64.c    | 14 +++++++-----
>  s390.c     |  4 ++--
>  s390x.c    |  4 ++--
>  9 files changed, 89 insertions(+), 33 deletions(-)
> 
> --
> 1.9.0
> 
>