[Crash-utility] issue: runq -g

[Dave Anderson]

----- Original Message -----
> Hi Dave,
> 
> I was getting the following error upon executing "runq -g".
> 
> runq: invalid structure member offset: cfs_rq_throttled
>       FILE: task.c  LINE: 7615  FUNCTION: print_group_header_fair()
> 
> [./crash] error trace: 80e98b0 => 80e9815 => 80e577f => 8143bde
>      TASK_GROUP: dac06c80  CFS_RQ: dac06080  <apps>runq: input string
> too large: "000000000808ec50" (16 vs 8)
> 
> "cfs_bandwidth" is available in task_group irrespective of whether
> CONFIG_CFS_BANDWIDTH is enabled or not (but empty). But "throttled" is
> available in cfs_rq only if config is enabled. The following patch
> fixes this.
> 
> diff --git a/task.c b/task.c
> index dc0310a..a119c60 100755
> --- a/task.c
> +++ b/task.c
> @@ -7611,7 +7611,7 @@ print_group_header_fair(int depth, ulong cfs_rq, void
> *t)
>         if (tgi->name)
>                 fprintf(fp, " <%s>", tgi->name);
> 
> -       if (VALID_MEMBER(task_group_cfs_bandwidth)) {
> +       if (VALID_MEMBER(cfs_rq_throttled)) {
>                 readmem(cfs_rq + OFFSET(cfs_rq_throttled), KVADDR,
>                         &throttled, sizeof(int), "cfs_rq throttled",
>                         FAULT_ON_ERROR);
> 
> Thanks,
> Vinayak
> 

Hi Vinayak,

Sorry for the delay -- I was on company break...

Queued for crash-7.0.5.

Thanks,
  Dave