[Crash-utility] [RFC PATCH 2/2] crash: kill dump_zone_page_usage()

[Dave Anderson]

----- Original Message -----
> On Fri 2014-11-21 11:45 -0500, Dave Anderson wrote:
> > ----- Original Message -----
> > > Most of the information provided by this function is duplicated in
> > > dump_zone_stats(). Also dump_zone_stats() is perhaps more useful.
> > > As such let's just remove dump_zone_page_usage().
> > 
> > Interesting -- I cannot even find a kernel version that satisfies
> > the structure-member-existance requirements in order for the zone
> > statistics to even be displayed by that function.  But there
> > must have been some range of kernel releases where it did work,
> > so I'd prefer to just leave the function alone, albeit in a
> > comatose state.
> > 
> > However, since it's so exceedingly rare, I agree that it's worth
> > removing it from the "help kmem" display.  (and for those antique
> > kernels where it still applies, it's just an added bonus)
> 
> Sure that's fine - in which case I'll have to adjust dump_zone_page_usage()
> to be aligned with the proposed changes to dump_kmeminfo().

I wouldn't even bother.  It's quite possible that the two are mutually
exclusive anyway.  I didn't look at the display changes, but just would
ask that you don't exceed 80 columns.

Thanks,
  Dave


> 
> Thanks,
> 
> --
> Aaron Tomlin
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
>