[Crash-utility] [RFC PATCH 1/2] crash: Show memory overcommit data in dump_kmeminfo()

Aaron Tomlin atomlin at redhat.com
Sun Nov 30 15:22:40 UTC 2014


On Fri 2014-11-21 15:50 -0500, Dave Anderson wrote:
> Sure enough, in a 2.6.30 kernel, which has no "sysctl_overcommit_kbytes", I get
> a SIGFPE on this line:
> 
>                        pct = committed ? ((committed * 100)
>                                         / allowed) : 0;
> 
> because sysctl_overcommit_kbytes doesn't exist.  I don't know what 
> the initial setting should be, because certainly 0 won't work.

OK - I've changed the logic so that if "sysctl_overcommit_kbytes" does not
exist or if set to 0, then we fall back to using "sysctl_overcommit_ratio"
in the calculation for "allowed" as per normal.

-- 
Aaron Tomlin




More information about the Crash-utility mailing list