[Crash-utility] [PATCH v6 ] crash-gcore-command extension module: PPC64 support
Dave Anderson
anderson at redhat.com
Fri Oct 17 18:17:01 UTC 2014
----- Original Message -----
>
>
> Hello Daisuke,
>
> Attached is a patch that introduces support for the PPC64 architecture.
> The patch was written by Michal Toman (mtoman at redhat.com). It is based
> upon crash-gcore-command-1.3.0-rc.
>
> The patch supports both big-endian and little-endian formats. However,
> it does require the ELF_DATA fix to elf64_fill_elf_header() that I reported
> yesterday. I have attached a separate patch to fix elf64_fill_elf_header
> and elf32_fill_elf_header().
>
> Please include these two patches in crash-gcore-command-1.3.0.
Hi Daisuke,
Can you please replace the add-ppc64-v5.patch with the attached add-ppc64-v6.patch?
The change consists of one line that replaces the (non-existent) "PPC64LE" test
with the __BYTE_ORDER test:
+ifndef ELF_DATA
+#ifdef PPC64LE
+#define ELF_DATA ELFDATA2LSB
+#else
+#define ELF_DATA ELFDATA2MSB
+#endif
+#endif
to this:
+#ifndef ELF_DATA
+#if __BYTE_ORDER == __LITTLE_ENDIAN
+#define ELF_DATA ELFDATA2LSB
+#else
+#define ELF_DATA ELFDATA2MSB
+#endif
+#endif
Actually it's highly unlikely that ELF_DATA will *not* be defined, but
just in case there are distributions where the #include file path does
not pick up /usr/include/asm/elf.h, then the change above will resolve it.
Thanks,
Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ELF_DATA.patch
Type: text/x-patch
Size: 963 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20141017/444f8b44/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-ppc64-v6.patch
Type: text/x-patch
Size: 6483 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20141017/444f8b44/attachment-0001.bin>
More information about the Crash-utility
mailing list