[Crash-utility] Unknown osrelease information in vmcore with xen

[Dave Anderson]

----- Original Message -----

> Thanks the patch works very well!
> Only a minor nit, now the n_type has changed:
> 
> Elf64_Nhdr:
>                n_namesz: 15 ("VMCOREINFO_XEN")
>                n_descsz: 4068
>                  n_type: 0 (?)
> 
> I'm not familiar enough what should be the right one:
>  "n_type: 0 (?)" or "n_type: 0 (unused)"
> 
> If the second this works for 64 bit:
> --- a/netdump.c
> +++ b/netdump.c
> @@ -2231,6 +2231,8 @@ dump_Elf64_Nhdr(Elf64_Off offset, int store)
>                 } else if (qemuinfo) {
>                         pc->flags2 |= QEMU_MEM_DUMP_ELF;
>                         netdump_print("(QEMUCPUState)\n");
> +               } else if (vmcoreinfo_xen) {
> +                        netdump_print("(unused)\n");
>                  } else
>                          netdump_print("(?)\n");
>                  break;
> 

Yes, that is definitely better.  I've added it to to both 32 and 64 bit,
and queued the patch for crash-7.1.4:

  https://github.com/crash-utility/crash/commit/2515ef355f96da7e6cffad18dc8985babab15d30

Thanks,
  Dave