[Crash-utility] [PATCH] take Hardware Error & kernel pointer bug as separate panicmsg

[Derek Cheng]

On Tuesday, February 3, 2015 8:03 AM, Dave Anderson <anderson at redhat.com> wrote:
> Derek,
> I don't understand what you're expecting me to do -- pick one of the 4 patches?


When I repost, only the last one is the updated patch,
> Can you please repost just one patch?

> And this part clearly cannot be applied, because the "SysRq :" string would
> also be displayed by all of the possible sysrq letters:

> +    while (!msg_found && fgets(buf, BUFSIZE, pc->tmpfile)) {
> +        if (strstr(buf, "SysRq : "))
> +            msg_found = TRUE;
> +    }


So, are you ok with other lines of the patch?

I've just found the code has these lines below, will update the patch and repost,

while (!msg_found && fgets(buf, BUFSIZE, pc->tmpfile)) {
if (strstr(buf, "SysRq : Netdump") ||
strstr(buf, "SysRq : Trigger a crashdump") ||
strstr(buf, "SysRq : Crash") ||
strstr(buf, "SysRq : Trigger a crash")) {
pc->flags |= SYSRQ;
msg_found = TRUE;
}
}


Thanks,