[Crash-utility] patch to read vmware vmss file

[Dave Anderson]

----- Original Message -----
> Dave,
> 
>   thanks for the review and here is the new patch. changes from the last
>   version.
> 
> * add GPL license header
> * remove stdbool.h
> * complete function declaration
> * add header file dependency in Makefile.
> * fit VMWARE_VMSS to flag.

OK thanks.  

So far I have made a few very minor additions.  First, in main():

 (1) The is_vmware_vmss() check should be preceded by the same "too many
     dumpfiles" check that all of other dumpfile types do.
 (2) I added write_vmware_vmss to the writemem_function_name() function
     (since it does exist and you make the assignment).

And in the is_vmware_vmss() function:

 (1) The error message for the fopen() failure cannot happen because
     a read-only check is done for all command line files in main() before
     checking what they are.  But nonetheless, I left the error message
     in place, encompassed by CRASHDEBUG(1).
 (2) The call to is_vmware_vmss() should not unconditionally print error
     messages if the dumpfile is not a vmss file; the purpose of the function
     is simply to confirm or deny whether it's a vmss file.  So, similar to
     other dumpfile types, I encompassed the hdr.id validation error message
     with CRASHDEBUG(1).

> addition to the source file change,
> * vmss file samples.
>   for vSphere ESX, memory dump is part of the vmss file;
>   for VMware Workstation, memory dump stores in a companion vmem file.
> 
>    https://www.dropbox.com/sh/fe8cdwxg1mw97or/AADSDfKDc8dHgh2AIBrMJE1za?dl=0
>    - CentOS6.5-11bd56db.vmss - CentOS6.5/vSphere 5.5
>      kernel-debuginfo-2.6.32-431.el6.x86_64.rpm  - symbol
>      kernel-debuginfo-common-x86_64-2.6.32-431.el6.x86_64.rpm - source
> 
>    - Ubuntu1404_64bit-65993542.vmss - Ubuntu14.04/Workstation 11
>      Ubuntu1404_64bit-65993542.vmem - companion memory dump
>      linux-image-3.13.0-39-generic-dbgsym_3.13.0-39.66_amd64.ddeb - symbol

How do I extract the vmlinux-3.13.0-39-generic file?

Dave