[Crash-utility] task: recursive temporary file usage

[Dave Anderson]

>> Hi,
>>
>> If I try to print a non-existing member of task_struct with foreach, I
>> get
>> expected error messages:
>>
>>  crash> foreach task -R invalid
>>  PID: 0      TASK: 806d9d30  CPU: 0   COMMAND: "swapper/0"
>>  task: invalid: not a task_struct or thread_info member
>>
>>  PID: 0      TASK: 8fce2808  CPU: 1   COMMAND: "swapper/1"
>>  task: invalid: not a task_struct or thread_info member
>>
>>  PID: 1      TASK: 8fc9c768  CPU: 0   COMMAND: "systemd"
>>  task: invalid: not a task_struct or thread_info member
>>
>> But, if I try to do this with a non-existing submember of an existing
>> member, I get 'recursive temporary file usage':
>>
>>  crash> foreach task -R se.invalid
>>  PID: 0      TASK: 806d9d30  CPU: 0   COMMAND: "swapper/0"
>>  task: invalid data structure member reference: se.invalid
>>  task: recursive temporary file usage
>>  task: recursive temporary file usage
>>  task: recursive temporary file usage
>>  task: recursive temporary file usage
>>
>> This is with the the latest crash from git.  I think this started from
>> the patches which introduced the deep-printing of structures.  I haven't
>> investigated further yet, though.
>
> It's because that new parse_for_member_extended() function does the
> error(FATAL) call while within a open_tmpfile()/close_tmpfile() section.
>
> Dave

I've queued a fix for crash-7.1.2:

  https://github.com/crash-utility/crash/commit/c69e75877da50778f957a3b283d75806c73ada91

Thanks for the report,
  Dave


>
>>
>> Thanks.
>>
>> /Rabin
>>
>> --
>> Crash-utility mailing list
>> Crash-utility at redhat.com
>> https://www.redhat.com/mailman/listinfo/crash-utility
>>
>>
>
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
>
>