[Crash-utility] [PATCH 2/2] dis: Report duplicate symbols

Dave Anderson anderson at redhat.com
Wed Jul 8 21:16:14 UTC 2015


Hi Aaron,

I was revisiting your v1 patch, and realized that the duplicate symbol check
also needs to apply to the "can_eval()" section as well, because a user could
enter "dis symbol+<offset>".  

So I extracted your do-while loop into a discrete function, and beefed it
up to handle the entry of symbols with multiple text and data symbols, as
well as some other possibilities.  In so doing, things got a bit murkier 
than your original patch.  I've attached what I've come up with so far.
Tell me what you think.

Thanks,
  Dave


-------------- next part --------------
A non-text attachment was scrubbed...
Name: dis.patch
Type: text/x-patch
Size: 5316 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20150708/b6d6173e/attachment.bin>


More information about the Crash-utility mailing list