[Crash-utility] Speed up list/tree '-s' output.

[Dave Anderson]

----- Original Message -----
> 
> 
> ----- Original Message -----
> > Hi Dave,
> > 
> > I've updated the patch, leaving all existing fields and routines.
> > https://raw.githubusercontent.com/hziSot/crash-patches/master/crash_speed_up_tree_list.patch
> 
> OK, thanks.
> 
> Did you set the -S argument limit at 8 because you felt that the existing -s option had
> prevented you from using hq_enter()?  If so, it would be preferable to make the -s and -S
> options mutually exclusive, and therefore allow -S to accept an unlimited
> number of entries.

Another suggestion:  

Use MEMBER_TYPE(), or pass a datatype_member structure to datatype_info(), in
order to determine whether a structure member is TYPE_CODE_PTR, and if so, always 
print the member in hexadecimal regardless of the current radix.  (i.e. like
gdb does)

Dave

> 
> > 
> > Thanks,
> > Alexandr
> > ________________________________________
> > From: crash-utility-bounces at redhat.com <crash-utility-bounces at redhat.com>
> > on
> > behalf of Dave Anderson <anderson at redhat.com>
> > Sent: Wednesday, August 17, 2016 21:19
> > To: Discussion list for crash utility usage,    maintenance and development
> > Subject: Re: [Crash-utility] Speed up list/tree '-s' output.
> > 
> > ----- Original Message -----
> > > Hi Dave,
> > >
> > > I've uploaded new patch:
> > > https://raw.githubusercontent.com/hziSot/crash-patches/master/crash_speed_up_tree_list.patch
> > >
> > > Thanks,
> > > Alexandr
> > 
> > Hi Alexandr,
> > 
> > Right from the get-go, this patch needs to be reworked to maintain
> > backwards-compability w/respect to pre-existing users of the list_data
> > structure, and by extension, the do_list(), do_rbtree() and do_rdtree()
> > functions, which may be used by pre-existing extension modules.  While you
> > do maintain the original -s options to both the list and tree commands, you
> > rip out the structure members the original data structures used, and the
> > simple code pieces that used them.  So I can't accept that kind of change.
> > 
> > Can you please make it so the original structname and structname_args
> > members will still be used by the -s options, and segregate your newly
> > added functionality?  You can still add stuff to the end of exported
> > list_data and tree_data structures.
> > 
> > Thanks,
> >   Dave
> > 
> > 
> > --
> > Crash-utility mailing list
> > Crash-utility at redhat.com
> > https://www.redhat.com/mailman/listinfo/crash-utility
> > 
>