[Crash-utility] PATCH v2 00/10] teach crash to work with "live" ramdump
Oleg Nesterov
oleg at redhat.com
Mon May 2 15:38:54 UTC 2016
On 05/02, Dave Anderson wrote:
>
> > So how should I define LOCAL_ACTIVE() ? As for this patchset I can equally do
> >
> > #define LOCAL_ACTIVE() ((pc->flags & (LIVE_SYSTEM|LIVEDUMP)) == LIVE_SYSTEM)
> >
> > I do not like this because I still think that LOCAL_ACTIVE doesn't need to
> > know about LIVEDUMP added by this series, but I won't argue.
>
> I have no problem with LOCAL_ACTIVE() being defined like that.
OK, so I will keep it for now...
> However, now I'm wondering whether "LIVEDUMP" should be renamed to differentiate it
> from LIVE_DUMP. LIVE_DUMP means one of two things:
>
> (1) On an s390x, a dumpfile was take by firmware of a running system.
> (2) The snap.so extension module was used to create an ELF vmcore of a running system.
>
> So both are static dumpfiles, but were taken while the system was running live.
>
> In this case, it's more like /dev/mem et al, and it's non-static. Maybe "LIVE_RAMDUMP"?
Agreed, LIVE_RAMDUMP looks much better.
OK, I'll add this change too and send you V3.
Oleg.
More information about the Crash-utility
mailing list