[Crash-utility] PATCH v2 00/10] teach crash to work with "live" ramdump

Dave Anderson anderson at redhat.com
Mon May 2 15:52:25 UTC 2016



----- Original Message -----
> On 05/02, Oleg Nesterov wrote:
> >
> > On 05/02, Dave Anderson wrote:
> > >
> > > > So how should I define LOCAL_ACTIVE() ? As for this patchset I can
> > > > equally do
> > > >
> > > > 	#define LOCAL_ACTIVE() ((pc->flags & (LIVE_SYSTEM|LIVEDUMP)) ==
> > > > 	LIVE_SYSTEM)
> > > >
> > > > I do not like this because I still think that LOCAL_ACTIVE doesn't need to
> > > > know about LIVEDUMP added by this series, but I won't argue.
> > >
> > > I have no problem with LOCAL_ACTIVE() being defined like that.
> >
> > OK, so I will keep it for now...
> 
> Ah, when I re-read I suspect I misunderstood... So you want me to define LOCAL_ACTIVE() as
> 
> 	LIVE_SYSTEM && !LIVE_RAMDUMP
> 
> right?

Yes.




More information about the Crash-utility mailing list