[Crash-utility] [PATCH 1/2] memory.c: fix missing printf flags in INFO message in page_flags_init_from_pageflag_names()

[Dave Anderson]

OK thanks, Andrey -- queued for crash-7.1.6:
 
  https://github.com/crash-utility/crash/commit/7136bf8495948cb059e5595b8503f8ae37019fa1

Dave


----- Original Message -----       
> On 19 May, Dave Anderson wrote:
> > 
> > Hi Andrey,
> > 
> > Thanks for this patch.  Can you tell me what "kmem -g" shows?
> 
> For kernel 4.6.0
> 
> crash> kmem -g
> PAGE-FLAG       BIT  VALUE
> PG_locked         0  000001
> PG_error          1  000002
> PG_referenced     2  000004
> PG_uptodate       3  000008
> PG_dirty          4  000010
> PG_lru            5  000020
> PG_active         6  000040
> PG_slab           7  000080
> PG_owner_priv_1   8  000100
> PG_arch_1         9  000200
> PG_reserved      10  000400
> PG_private       11  000800
> PG_private_2     12  001000
> PG_writeback     13  002000
> PG_head          14  004000
> PG_swapcache     15  008000
> PG_mappedtodisk  16  010000
> PG_reclaim       17  020000
> PG_swapbacked    18  040000
> PG_unevictable   19  080000
> PG_mlocked       20  100000
> PG_uncached      21  200000
> PG_hwpoison      22  400000
> PG_checked        8  000100
> PG_fscache       12  001000
> PG_pinned         8  000100
> PG_savepinned     4  000010
> PG_foreign        8  000100
> PG_slob_free     11  000800
> PG_double_map    12  001000
> 
> 
> 
> > 
> > Dave
> > 
> > 
> > ----- Original Message -----
> > > Signed-off-by: Andrey Skvortsov <andrej.skvortzov at gmail.com>
> > > ---
> > >  memory.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/memory.c b/memory.c
> > > index 275fc34..d6271bc 100644
> > > --- a/memory.c
> > > +++ b/memory.c
> > > @@ -6353,7 +6353,7 @@ page_flags_init_from_pageflag_names(void)
> > >  		}
> > >  
> > >  		if (!read_string((ulong)name, namebuf, BUFSIZE-1)) {
> > > -			error(INFO, "failed to read pageflag_names entry\n",
> > > +			error(INFO, "failed to read pageflag_names entry (i: %d, name:
> > > \"%s\",
> > > mask:%d)\n",
> > >  				i, name, mask);
> > >  			goto pageflags_fail;
> > >  		}
> > > --
> > > 2.8.1
> > > 
> > > 
> 
> --
> Best regards,
> Andrey Skvortsov
>