[Crash-utility] [PATCH v2] struct: Fix handing of percpu symbols (when symbolic argument only)

Dave Anderson anderson at redhat.com
Thu Sep 29 15:50:58 UTC 2016



----- Original Message -----

> +			if (ptype) {
> +				open_tmpfile();
> +				snprintf(buf, sizeof buf, "p *(%s*) 0x%lx",
> +						typename, cpuaddr);
> +				gdb_pass_through(buf, pc->tmpfile, GNU_RETURN_ON_ERROR);
> +
> +				rewind(pc->tmpfile);
> +				fgets(buf, BUFSIZE, pc->tmpfile);
> +				parse_line(buf, argv);
> +				cpuaddr = htol(argv[3], FAULT_ON_ERROR, NULL);
> +				close_tmpfile();
> +			}
> +
>  			fprintf(fp, "%lx\n", cpuaddr);
>  			do_datatype_addr(dm, cpuaddr , count,

And I'm not clear the gdb_pass_through() is required here?  Can't you
just do a simple readmem() of the cpuaddr location?

Dave




More information about the Crash-utility mailing list