[Crash-utility] [PATCH] Fix for "kmem <addr>" for kernels configured with CONFIG_SLUB and SLAB_RED_ZONE.

[Dave Anderson]

----- Original Message -----
> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:
> 
> >> Attached is a patch for your review.  You will have to
> >> enter "set redzone on" in order for the adjusted object
> >> addresses to be displayed.
> >
> > Thanks! This seems to be what I want.
> 
> While testing this patch, I noticed what you pointed out in my
> patch. Right, the part comparing "si->spec_addr" with "p" is wrong.
>
> redzone.patch is version of fixed my bug (removed trailing whitespace too).

Right, but I based my last patch on your first patch, which modified
the "vaddr" variable before making the "is_free" check.  Either way works. 

> 
> And while testing, I confused whether "redzone on" is meaning exclude or
> not (because "redzone on" looks like "show redzone")? :)
> So redzone-exclude.patch renamed "redzone" to "exclude_redzone".  This
> patch can be rejected freely if you don't want.

OK, but I'll just change the on/off logic and the help page description
such that:

   redzone on:  object addresses will point to the object base, which is
                the redzone region if enabled.  (the default)
  redzone off:  object addresses will point to the address returned to
                the allocator.

Thanks,
  Dave