[Crash-utility] feature to dump audit logs in vmcore

Hatayama, Daisuke d.hatayama at jp.fujitsu.com
Tue Mar 14 12:00:23 UTC 2017


> > > Given that those 3 members are all pointer types, you could just use
> > > "sizeof(void *)" for the readmem() calls, as is done throughout the
> > > crash code.  Note that there are not any MEMBER_SIZE_INIT() callers
> > > for structure members that are known, guaranteed, pointer values.
> >
> > I'm doing this considering x86 build as x86_64 binary where pointer size
> > differs, or is this unnecessary for such x86 build? Sorry, I didn't test
> > x86 build as x86_64 binary.
> 
> With "make target=x86", crash is built with -m32 to create a 32-bit x86 binary
> that runs on an x86_64 host, so kernel pointer sizes will always be the same
> as the crash binary.

I was confused this.

I made the 2nd version of the patch and reflected your comments in it.
Could you review this?

Thanks.
HATAYAMA, Daisuke

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-feature-to-dump-audit-logs-in-log-command-as-a.patch
Type: application/octet-stream
Size: 13637 bytes
Desc: 0001-Add-a-feature-to-dump-audit-logs-in-log-command-as-a.patch
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20170314/23d1fa7c/attachment.obj>


More information about the Crash-utility mailing list