[Crash-utility] [PATCH] fix "ps -l"

Dave Anderson anderson at redhat.com
Fri Nov 3 13:25:15 UTC 2017


Hi Vinayak,

Thanks for catching that, a regression caused by the new "ps -y" patch.

Queued for crash-7.2.1:

  https://github.com/crash-utility/crash/commit/f852f5ce4d28f88308f0e555c067e63e3edd7f37
  
Dave


----- Original Message -----
> fix segfault when executing "ps -l".
> 
> Signed-off-by: Vinayak Menon <vinayakm.list at gmail.com>
> ---
>  task.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/task.c b/task.c
> index 5754159..f2628b7 100644
> --- a/task.c
> +++ b/task.c
> @@ -3485,7 +3485,7 @@ show_last_run(struct task_context *tc, struct psinfo
> *psi)
>         sprintf(format, "[%c%dll%c] ", '%', c,
>                 pc->output_radix == 10 ? 'u' : 'x');
> 
> -       if (psi) {
> +       if (psi && psi->cpus) {
>                 for (c = others = 0; c < kt->cpus; c++) {
>                         if (!NUM_IN_BITMAP(psi->cpus, c))
>                                 continue;
> --
> 




More information about the Crash-utility mailing list