[Crash-utility] [PATCH v3 0/2] Fix KASLR problem on sadump

[Dave Anderson]

Hi Takao,

Nicely done -- very clean and non-intrusive!

Given the changes from the v1 version that Daisuke commented on,
and because I don't have an sadump dumpfile to test, I will defer
to Daisuke to ACK this version before checking it into github.

Thanks,
  Dave


----- Original Message -----
> Hi Dave, Hatayama-san,
> 
> These patch series fix a problem that crash cannot open a dumpfile which is
> captured by sadump on KASLR enabled kernel.
> 
> When KASLR feature is enabled, a kernel is placed on the memory randomly and
> therefore crash cannot open a dumpfile because addresses of kernel symbols in
> vmlinux are different from actual addresses. In the case of kdump, information
> to get actual address is included in the vmcoreinfo, but dumpfile of sadump does
> not have such a information.
> 
> These patches calculate kaslr offset and phys_base to solve this problem. The
> basic idea is getting register (IDTR and CR3) from dump header, and calculate
> kaslr_offset/phys_base using them.
> 
> changelog:
> v3:
> - Rebase on the latest branch
> - Fix to get rid of compile warnings except x86_64
> - Implement patch 1/2 without adding new function into x86_64.c
> 
> v2:
> https://www.redhat.com/archives/crash-utility/2017-October/msg00018.html
> - Remove virsh-dump part
> - Change get_vec0_addr style
> - Some tiny fixes
> 
> v1:
> https://www.redhat.com/archives/crash-utility/2017-October/msg00004.html
> 
> Takao Indoh (2):
>   Call x86_64_kvtop during symtab_init() for sadump
>   Fix a KASLR problem of sadump
> 
>  defs.h    |   4 +
>  sadump.c  | 465
>  +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  sadump.h  |   1 +
>  symbols.c |  34 +++++
>  x86_64.c  |  21 +++
>  5 files changed, 524 insertions(+), 1 deletion(-)
> 
> --
> 2.9.5
> 
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
>