[Crash-utility] [PATCH RFC 14/14] symbols: format string should be never empty

Oleksandr Natalenko oleksandr at redhat.com
Fri Oct 27 08:23:20 UTC 2017


Signed-off-by: Oleksandr Natalenko <oleksandr at redhat.com>
---
 symbols.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/symbols.c b/symbols.c
index 8a4c878..3e4c37a 100644
--- a/symbols.c
+++ b/symbols.c
@@ -12549,10 +12549,11 @@ patch_kernel_symbol(struct gnu_request *req)
 			    "\nkernel relocated [%ldMB]: patching %ld gdb minimal_symbol values\n",
 				relocate_display, st->symcnt);
 		}
-                fprintf(fp, (pc->flags & SILENT) || !(pc->flags & TTY) ? "" :
-                 "\nplease wait... (patching %ld gdb minimal_symbol values) ",
-			st->symcnt);
-		fflush(fp);
+		if (!((pc->flags & SILENT) || !(pc->flags & TTY))) {
+			fprintf(fp, "\nplease wait... (patching %ld gdb minimal_symbol values) ",
+				st->symcnt);
+			fflush(fp);
+		}
 		req->count = 0;
 		req->length = 0;
 		req->last_sp = 0;
-- 
2.14.3




More information about the Crash-utility mailing list