[Crash-utility] [PATCH RFC 00/14] Minor code cleanups, round zero

[Oleksandr Natalenko]

Hi, Dave, Daisuke.

> OK, mystery solved.
> …
> Regardless, I fixed the patch to be based upon the kernel version, and queued
> it for crash-7.1.2:
>
>  https://github.com/crash-utility/crash/commit/e81db08bc69fb1a7a7e48f892c2038d992a71f6d

Thanks for looking into it, now it makes more sense to me.

> Probably it should just set addr_d = addr - amount, but that's what the code effectively
> does now (by mistake), so I'm just going to leave this alone.

Would you, maybe, still prefer modifying it to addr_d = addr - amount
anyway to avoid both
compiler and code reviewer confusion in the future please?

> It's pretty much impossible to have a pml without its PAGE_PRESENT bit set,
> so it's been a benign bug.  But the fix is incorrect.  They should be:
>
>        if (!(*pml4 & _PAGE_PRESENT))

Thanks for the explanation. Would you still prefer changing it to a
proper expression
since original one is confusing (NOT is evaluated before &)?

> Oleksandr, this looks good to me.
> Thanks for your patch.

Thank you for looking into it. Dave, would you prefer applying this
patch directly now?

Also, I'd still like to get a response regarding other patches in the
series once you have
some time.

Thanks!