[Crash-utility] [PATCH RFC 05/14] x86_64: clarify logical operator precedence

[Dave Anderson]

A fix has been queued for crash-7.2.1:

  https://github.com/crash-utility/crash/commit/0f40db8fbac538ea448bbb2beb44912e4c43a54a

Thanks,
  Dave


----- Original Message -----
> Signed-off-by: Oleksandr Natalenko <oleksandr at redhat.com>
> ---
>  x86_64.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/x86_64.c b/x86_64.c
> index 2f9e6db..7b25e60 100644
> --- a/x86_64.c
> +++ b/x86_64.c
> @@ -2086,7 +2086,7 @@ x86_64_kvtop(struct task_context *tc, ulong kvaddr,
> physaddr_t *paddr, int verbo
>  	}
>  
>  start_vtop_with_pagetable:
> -	if (!(*pml4) & _PAGE_PRESENT)
> +	if ((!(*pml4)) & _PAGE_PRESENT)
>  		goto no_kpage;
>  	pgd_paddr = (*pml4) & PHYSICAL_PAGE_MASK;
>  	FILL_PGD(pgd_paddr, PHYSADDR, PAGESIZE());
> @@ -2187,7 +2187,7 @@ x86_64_kvtop_xen_wpt(struct task_context *tc, ulong
> kvaddr, physaddr_t *paddr, i
>  		fprintf(fp, "PML4 DIRECTORY: %lx\n", vt->kernel_pgd[0]);
>                  fprintf(fp, "PAGE DIRECTORY: %lx [machine]\n", *pml4);
>  	}
> -	if (!(*pml4) & _PAGE_PRESENT)
> +	if ((!(*pml4)) & _PAGE_PRESENT)
>  		goto no_kpage;
>  	pgd_paddr = (*pml4) & PHYSICAL_PAGE_MASK;
>  	pgd_paddr = xen_m2p(pgd_paddr);
> --
> 2.14.3
> 
>