[Crash-utility] [PATCH RFC 12/14] sadump: block_size is always non-negative

[Dave Anderson]

----- Original Message -----
> > ... [ cut ] ...
> > 
> > And I'm not sure whether this one should be fixed by just removing the statement:
> > 
> > --- a/sadump.c
> > +++ b/sadump.c
> > @@ -157,9 +157,6 @@ read_dump_header(char *file)
> >          }
> > 
> >  restart:
> > -        if (block_size < 0)
> > -                return FALSE;
> > -
> >          if (!read_device(sph, block_size, &offset)) {
> >                  error(INFO, "sadump: cannot read partition header\n");
> >                  goto err;
> > 
> > 
> > because farther down there is this:
> > 
> >         if (sh->block_size != block_size) {
> >                 block_size = sh->block_size;
> >                 offset = 0;
> >                 goto restart;
> >         }
> > 
> > I'll let the sadump maintainer decide how to deal with this one.  He's on
> > this list, but I've cc'd him to get his attention.
> 
> Thanks for telling me this, Dave.
> 
> Oleksandr, this looks good to me.
> Thanks for your patch.
> 
> block_size is of type size_t and size_t is always defined as
> some unsigned integer type in the C standards.
> So, the condition on block_size is meaningless and can be removed.
> 

Thanks for verifying the patch Daisuke -- queued for crash-7.2.1:

  https://github.com/crash-utility/crash/commit/9339874f3764fe99a408aec1a814b19c77f5dfe1

Dave