[Crash-utility] [PATCH 0/4] Add support to extract hardware device dumps from vmcore

[Dave Anderson]

Hi Surendra,

Your patch has been queued for crash-7.2.6:

  https://github.com/crash-utility/crash/commit/71a4f36767848e02f6f77fdbd6cb321151b84407

Thanks very much for this implementing this feature.

Dave


----- Original Message -----
> 
> Hi Surendra,
> 
> This version looks good.  I've been testing it today, and have tinkered
> around with a few minor things:
> 
>   1. Added vmcore.h to the Makefile for compile-dependency purposes.
>   2. Removed the requirement for the "-r" option, allowing just the file name
>      as an argument.
>   3. When dumping to the screen using the default -v output, the count argument
>      needs to be divided by the sizeof(uint64_t).
>   4. Tightened up the -V output format a bit.
>   5. Simplified the error handling, and made the error messages more common.
>   6. Moved the new vmcore_data structure entries to the end of the structure
>      just to prevent any possible backwards-compatibility issues with any
>      previously-build extension modules that use netdump.h.
>   7. Fixed up the help page.
> 
> There's also a couple "make warn" warnings when building a 32-bit binary
> that I'll look into.
> 
> Anyway, there's no need to repost anything, but since I'll be out of the
> office until next Tuesday, I'm just letting you know that it should be good
> to go and checked in by early next week.
> 
> Nice job,
>   Dave
> 
> 
> ----- Original Message -----
> > When kernel panic happens and kdump crash kernel is loaded, device
> > drivers enabled in the kdump crash kernel collect device specific
> > snapshot of the hardware/firmware state of their underlying devices.
> > These snapshots are exported as ELF notes with note type NT_VMCOREDD
> > (i.e., 0x700) in vmcore [1].
> > 
> > This series of patches enhance crash utility to analyze and
> > extract these hardware specific device dumps from vmcore using
> > "dev" command.
> > 
> > Patches 1 and 2 enhance help -D to parse NT_VMCOREDD ELF notes
> > in ELF vmcore and KDUMP vmcore, respectively.
> > 
> > Patches 3 and 4 enhance dev command to analyze and extract
> > hardware specific device dumps from ELF vmcore and KDUMP vmcore,
> > respectively.
> > 
> > Suggestions and feedback will be much appreciated.
> > 
> > Thanks,
> > Surendra
> > 
> > [1] https://lkml.org/lkml/2018/5/2/190
> > 
> > ---
> > rfc:
> > - Moved logic to extract device dumps from "devdump" to "dev" command,
> >   in patches 3 and 4.
> > - By default, device dumps are output to screen as hexdump, if output
> >   file is not provided.
> > 
> > Surendra Mobiya (4):
> >   parse NT_VMCOREDD ELF notes in ELF vmcore
> >   parse NT_VMCOREDD ELF notes in KDUMP vmcore
> >   enhance dev command to extract NT_VMCOREDD from ELF vmcore
> >   enhance dev command to extract NT_VMCOREDD from KDUMP vmcore
> > 
> >  defs.h     |  10 +++++
> >  dev.c      |  80 +++++++++++++++++++++++++++++++++++-
> >  diskdump.c |  84 ++++++++++++++++++++++++++++++++++++++
> >  help.c     |  23 ++++++++++-
> >  memory.c   |  10 +++++
> >  netdump.c  | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >  netdump.h  |   3 ++
> >  vmcore.h   |  36 ++++++++++++++++
> >  8 files changed, 359 insertions(+), 5 deletions(-)
> >  create mode 100644 vmcore.h
> > 
> > --
> > 2.21.0
> > 
> > 
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility
>