[Crash-utility] [RFC PATCH 0/1] support lockless printk ringbuffer
HAGIO KAZUHITO(萩尾 一仁)
k-hagio-ab at nec.com
Thu Apr 30 15:47:14 UTC 2020
Hi John,
> -----Original Message-----
> Hi Kazu,
>
> Here is a patch adding full support for the new lockless printk
> ringbuffer as it is currently being proposed. Note that the latest
> version has not yet been submitted to LKML. I was waiting until I
> finished tests with crash(8) and makedumpfile(8).
>
> The new ringbuffer will export all the necessary symbols, sizes,
> and offsets in VMCOREINFO.
>
> Note that I created a separate printk.c for the iteration logic.
That's good.
>
> Also note that I modified dwarf_info.c to support resolving
> typedefs of typedefs. This was necessary in order to support
> atomic_long_t and its "counter" member.
OK, I see.
>
> I don't expect you to take the patch as-is, but I hope it can
> provide some positive ground work for moving forward.
OK. It looks already well-considered.
Thank you very much for the patch!
Kazu
>
> John Ogness (1):
> printk: add support for lockless ringbuffer
>
> Makefile | 2 +-
> dwarf_info.c | 36 +++++++++-
> makedumpfile.c | 101 ++++++++++++++++++++++++++--
> makedumpfile.h | 25 +++++++
> printk.c | 177 +++++++++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 333 insertions(+), 8 deletions(-)
> create mode 100644 printk.c
>
> --
> 2.20.1
More information about the Crash-utility
mailing list