[Crash-utility] - [PATCH v2 2/3] vmware: vmss beautify and extend debug log

[Mathias Krause]

Hi Kazu,

Am 12.08.20 um 06:53 schrieb HAGIO KAZUHITO(萩尾 一仁):
> [...]
>> +					for (j = 0; j < VMW_CR64_SIZE / 8; j++)
>> +						DEBUG_PARSE_PRINT((ofp, "%s%016llX", j ? " " : "",
>> vmss.regs64[cpu]->cr[j]));
> 
> This warning is emitted.
> 
> $ make warn
> ...
> cc -c -g -DX86_64 -DSNAPPY -DLZO -DGDB_7_6  vmware_vmss.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security 
> vmware_vmss.c: In function ‘vmware_vmss_init’:
> vmware_vmss.c:250:7: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’ [-Wformat=]
>        DEBUG_PARSE_PRINT((ofp, "%s%016llX", j ? " " : "", vmss.regs64[cpu]->cr[j]));
>        ^
> 
> I'll fix when merging.
> 
> -                                               DEBUG_PARSE_PRINT((ofp, "%s%016llX", j ? " " : "", vmss.regs64[cpu]->cr[j]));
> +                                               DEBUG_PARSE_PRINT((ofp, "%s%016llX", j ? " " : "",
> +                                                               (ulonglong)vmss.regs64[cpu]->cr[j]));

Ah, you're right, I forgot the cast. Thanks for fixing this up!

Maybe some of the warnings in WARNING_OPTIONS should be enabled by default?

Thanks,
Mathias