[Crash-utility] [PATCH] extensions/eppic.mk: Remove ping checkto github.com

[lijiang]

在 2020年12月23日 01:00, crash-utility-request at redhat.com 写道:
> Date: Mon, 21 Dec 2020 23:54:26 +0000
> From: HAGIO KAZUHITO(?????) 	<k-hagio-ab at nec.com>
> To: lijiang <lijiang at redhat.com>, "crash-utility at redhat.com"
> 	<crash-utility at redhat.com>
> Subject: Re: [Crash-utility] [PATCH] extensions/eppic.mk: Remove ping
> 	check	to github.com
> Message-ID:
> 	<OSBPR01MB1991A487EDD6CA590B2959D5DDC00 at OSBPR01MB1991.jpnprd01.prod.outlook.com>
> 	
> Content-Type: text/plain; charset="utf-8"
> 
> Hi Lianbo,
> 
>> -----Original Message-----
>> From: lijiang <lijiang at redhat.com>
>> Sent: Monday, December 21, 2020 11:48 PM
>> To: crash-utility at redhat.com; HAGIO KAZUHITO(?????) <k-hagio-ab at nec.com>
>> Subject: Re:[PATCH] extensions/eppic.mk: Remove ping check to github.com
>>> Without this patch, in an environment where ping to github.com does
>>> not work, building eppic.so fails with the message "eppic.so: failed
>>> to pull eppic code from git repo" and "make clean" at the top-level
>>> crash directory unnecessarily takes about 10 seconds every time.
>>>
>>>   $ time make clean
>>>   ...
>>>   real    0m10.398s
>>>
>> This change is very helpful.
>>
>>> Signed-off-by: Kazuhito Hagio <k-hagio-ab at nec.com>
>>> ---
>>>  extensions/eppic.mk | 5 +----
>>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>> diff --git a/extensions/eppic.mk b/extensions/eppic.mk
>>> index c79170a596b7..7486ce46a6b8 100644
>>> --- a/extensions/eppic.mk
>>> +++ b/extensions/eppic.mk
>>> @@ -24,7 +24,6 @@ ifeq ($(TARGET), X86)
>>>  endif
>>>
>>>  APPFILE=eppic/applications/crash/eppic.c
>>> -GITHUB := $(shell ping -c 1 github.com | grep "1 received")
>> BTW: Is it possible to fix this issue with the option -W? For example:
>>
>> GITHUB := $(shell ping -c 1 -W 2 github.com | grep "1 received")
>>                             ^^^^
> No, this doesn't solve the former issue in an environment where ping
> doesn't work but "git clone" does work.  I have such an environment..
> 
Interesting. Seems that ping doesn't work because of the network policy
or other reason?

For my side, the -W option will provide a timeout.

> In the first place, what is the ping check needed for?  I'm not sure
> why it is there.  If it's for avoiding long timeout of "git clone",
> it would not be solved by the ping check everywhere, i.e. in a place
> where ping works but git clone doesn't work.  In this case, something
> like "timeout 20 git clone ..." might be better.
> 
This still depends on the network speed.

Anyway, this change looks good. Acked-by: Lianbo Jiang <lijiang at redhat.com>

> Thanks,
> Kazu
> 
>