[Crash-utility] [PATCH 1/2] Makefile: Mention arm and arm64 as supported targets

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Wed Jul 22 07:31:59 UTC 2020


Hi Bhupesh,

sorry for the late response.

> -----Original Message-----
> Update the Makefile comments to note that arm and arm64
> are also supported build targets.
> 
> Signed-off-by: Bhupesh Sharma <bhsharma at redhat.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 745541012f43..7062139e68bc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -20,7 +20,7 @@
>  PROGRAM=crash
> 
>  #
> -# Supported targets: X86 ALPHA PPC IA64 PPC64 SPARC64
> +# Supported targets: X86 ALPHA ARM ARM64 PPC IA64 PPC64 SPARC64

Hmm, what does this "Supported targets" mean here?
If it's the architectures that crash supports, then there is lack
(x86_64, mips and so on).
If it's the architectures that crash on x86_64 supports, then it's
not correct, e.g. alpha dumpfiles are not supported on x86_64 crash.

And we usually use "make target=xxx" to set this TARGET, not write
it here directly.

So I think this list is a bit confusing now, and I'd prefer to replace
it with something like "For supported targets, see README."  The README
file explains the supported architectures and usage of "make target=xxx".
How about this?

Thanks,
Kazu

>  # TARGET and GDB_CONF_FLAGS will be configured automatically by configure
>  #
>  TARGET=
> --
> 2.7.4





More information about the Crash-utility mailing list