[Crash-utility] [PATCH 1/2] Makefile: Mention arm and arm64 as supported targets

[HAGIO KAZUHITO(萩尾 一仁)]

Hi Bhupesh,

-----Original Message-----
> Hi Kazu,
> 
> On Wed, Jul 22, 2020 at 1:02 PM HAGIO KAZUHITO(萩尾　一仁)
> <k-hagio-ab at nec.com> wrote:
> >
> > Hi Bhupesh,
> >
> > sorry for the late response.
> >
> > > -----Original Message-----
> > > Update the Makefile comments to note that arm and arm64
> > > are also supported build targets.
> > >
> > > Signed-off-by: Bhupesh Sharma <bhsharma at redhat.com>
> > > ---
> > >  Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index 745541012f43..7062139e68bc 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -20,7 +20,7 @@
> > >  PROGRAM=crash
> > >
> > >  #
> > > -# Supported targets: X86 ALPHA PPC IA64 PPC64 SPARC64
> > > +# Supported targets: X86 ALPHA ARM ARM64 PPC IA64 PPC64 SPARC64
> >
> > Hmm, what does this "Supported targets" mean here?
> > If it's the architectures that crash supports, then there is lack
> > (x86_64, mips and so on).
> > If it's the architectures that crash on x86_64 supports, then it's
> > not correct, e.g. alpha dumpfiles are not supported on x86_64 crash.
> 
> This is a very fair point. Actually I talked about this with Dave A.
> earlier as I had similar doubts.
> He seemed to imply that Supported targets means architectures
> supported in 'make target' (at that time arm64 crash support was still
> been added to crash).
> 
> > And we usually use "make target=xxx" to set this TARGET, not write
> > it here directly.
> 
> Right.
> 
> > So I think this list is a bit confusing now, and I'd prefer to replace
> > it with something like "For supported targets, see README."  The README
> > file explains the supported architectures and usage of "make target=xxx".
> > How about this?
> 
> I agree. I think its confusing in the current state. Lets just remove
> this text from here and let's point to the README file here instead.
> 
> Please let me know if you want me to send a v2 with the README related
> change or would you like to fix/send the same.

(sorry, I had been off work again..)
could you send a v2?  That will be helpful.

Thanks,
Kazu

> 
> Thanks,
> Bhupesh
> 
> > >  # TARGET and GDB_CONF_FLAGS will be configured automatically by configure
> > >  #
> > >  TARGET=
> > > --
> > > 2.7.4
> >