[Crash-utility] [PATCH 2/4] symbols: fix initialization of st->{pti_init, kaiser}_vmlinux

d.hatayama at fujitsu.com d.hatayama at fujitsu.com
Mon Jul 27 05:47:18 UTC 2020


> >
> > diff --git a/symbols.c b/symbols.c
> > index b9de4a1..fa46e91 100644
> > --- a/symbols.c
> > +++ b/symbols.c
> > @@ -12692,20 +12692,25 @@ numeric_forward(const void *P_x, const void *P_y)
> >               else if (STREQ(y->name, "idt_table"))
> >                       st->idt_table_vmlinux = valueof(y);
> >
> > +             if (STREQ(x->name, "kaiser_init"))
> > +                     st->pti_init_vmlinux = valueof(x);
>
> Is this st->pti_init_vmlinux intended?
> If st->kaiser_init_vmlinux is correct, I can fix when merging.
>
> > +             else if (STREQ(y->name, "kaiser_init"))
> > +                     st->kaiser_init_vmlinux = valueof(y);
> > +
> >               if (STREQ(x->name, "linux_banner"))
> >                       st->linux_banner_vmlinux = valueof(x);
> >               else if (STREQ(y->name, "linux_banner"))
> >                       st->linux_banner_vmlinux = valueof(y);
> >
> > +             if (STREQ(x->name, "pti_init"))
> > +                     st->pti_init_vmlinux = valueof(x);
> > +             else if (STREQ(y->name, "pti_init"))
> > +                     st->kaiser_init_vmlinux = valueof(y);
>
> Ditto, but in reverse.
>

Yes. I'll fix this in the next version.

Thanks.
HATAYAMA, Daisuke






More information about the Crash-utility mailing list