[Crash-utility] [PATCH 4/4] kaslr: fix failure of calculating kaslr_offset due to an sadump format restriction

d.hatayama at fujitsu.com d.hatayama at fujitsu.com
Mon Jul 27 05:50:34 UTC 2020


> diff --git a/sadump.c b/sadump.c
> > index 35f7cf0..85b4a09 100644
> > --- a/sadump.c
> > +++ b/sadump.c
> > @@ -1666,21 +1666,24 @@ get_sadump_smram_cpu_state_any(struct sadump_smram_cpu_state *smram)
> >  {
> >          ulong offset;
> >          struct sadump_header *sh = sd->dump_header;
> > -        int apicid;
> > +        static int apicid;
> >          struct sadump_smram_cpu_state scs, zero;
>
> $ make clean
> $ make warn
> ...
> cc -c -g -DX86_64 -DSNAPPY -DLZO -DGDB_7_6  sadump.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security
> sadump.c: In function ‘get_sadump_smram_cpu_state_any’:
> sadump.c:1670:44: warning: unused variable ‘zero’ [-Wunused-variable]
>          struct sadump_smram_cpu_state scs, zero;
>                                             ^
>
> I can remove that zero when merging.

Thanks. But I'll post the next version.

Thanks.
HATAYAMA, Daisuke






More information about the Crash-utility mailing list