[Crash-utility] [PATCH v2] vmware_guestdump: new input format

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Thu Oct 8 01:38:26 UTC 2020


Hi Alexey,

thanks for the comments and update.

-----Original Message-----
> diff --git a/defs.h b/defs.h
> index c899fe2..f61f864 100644
> --- a/defs.h
> +++ b/defs.h
> @@ -655,6 +655,7 @@ struct new_utsname {
>  #define IRQ_DESC_TREE_RADIX        (0x40ULL)
>  #define IRQ_DESC_TREE_XARRAY       (0x80ULL)
>  #define KMOD_PAX                  (0x100ULL)
> +#define VMWARE_VMSS_GUESTDUMP     (0x200ULL)

sorry for lack of explanation.
I meant that the KMOD_PAX and etc. above are bit values for kt->flags2
and 0x200 is already used for pc->flags2 by GET_LOG, so it should be
added here:

--- a/defs.h
+++ b/defs.h
@@ -544,6 +544,7 @@ struct program_context {
 #define is_excluded_vmemmap() (pc->flags2 & EXCLUDED_VMEMMAP)
 #define MEMSRC_LOCAL         (0x80000ULL)
 #define REDZONE             (0x100000ULL)
+#define VMWARE_VMSS_GUESTDUMP  (0x200000ULL)
        char *cleanup;
        char *namelist_orig;
        char *namelist_debug_orig;

Otherwise, looks good to me.

Thanks,
Kazu





More information about the Crash-utility mailing list