[Crash-utility] [PATCH v3] vmware_guestdump: new input format

[HAGIO KAZUHITO(萩尾 一仁)]

-----Original Message-----
> vmware_guestdump is extension to vmware_vmss with ability to debug
> debug.guest and debug.vmem files.
> 
> debug.guest.gz and debug.vmem.gz can be obtained using following
> .vmx options from VM running in debug mode:
>     monitor.mini-suspend_on_panic = TRUE
>     monitor.suspend_on_triplefault = TRUE
> 
> guestdump (debug.guest) is simplified version of *.vmss which does
> not contain full VM state, but minimal guest state, such as memory
> layout and CPUs state, needed for debugger. is_vmware_guestdump()
> and vmware_guestdump_init() functions parse guestdump header and
> populate vmss data structure (from vmware_vmss.c). As result, all
> handlers (except mempry_dump) from vmware_vmss.c can be reused.
> 
> How to use: $ crash /path/to/debug_file.guest vmlinux
> Companion debug_file.vmem must be present in the same folder as
> debug_file.guest. Otherwise crash will shot a message:
>  vmw: Open the companion vmem file: /path/to/debug_file.vmem
>  crash: vmw: /path/to/debug_file.vmem: No such file or directory
> 
> Signed-off-by: Alexey Makhalov <amakhalov at vmware.com>

The v3 patch looks good to me.

Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>

Lianbo, Bhupesh, can you double-check this as well?

Thanks,
Kazu