[Crash-utility] [PATCH] sadump: fix help -D lists uninteresting register entries

[HAGIO KAZUHITO(萩尾 一仁)]

-----Original Message-----
> Reserved fields in SMRAM CPU states could be non-zero even if the
> corresponding APICs are NOT used. This breaks the assumption that
> SMRAM CPU state is zero cleared if and only if the APIC corresponding
> to the entry is NOT used. As the result, help -D lists uninteresting
> entries as below:
> 
>   APIC ID: 14
>       RIP: 0000000000000000 RSP: 0000000000000000 RBP: 0000000000000000
>       RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
>       RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
>       R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000
>       R11: 0000000000000000 R12: 0000000000000000 R13: 0000000000000000
>       R14: 0000000000000000 R15: 0000000000000000
>       SMM REV: 00000000 SMM BASE 00000000
>       CS : 00000000 DS: 00000000 SS: 00000000 ES: 00000000 FS: 00000000
>       GS : 00000000
>       CR0: 0000000000000000 CR3: 0000000000000000 CR4: 00000000
>       GDT: 0000000000000000 LDT: 0000000000000000 IDT: 0000000000000000
>       GDTlim: 00000000 LDTlim: 00000000 IDTlim: 00000000
>       LDTR: 00000000 TR: 00000000 RFLAGS: 0000000000000000
>       EPTP: 0000000000000000 EPTP_SETTING: 00000000
>       DR6: 0000000000000000 DR7: 0000000000000000
>       Ia32Efer: 0000000000000000
>       IoMemAddr: 0000000000000000 IoEip: 0000000000000000
>       IoMisc: 00000000 LdtInfo: 00000000
>       IoInstructionRestart: 0000 AutoHaltRestart: 0000
> 
> To fix this issue, mask reserved fields before comparison.
> 
> Signed-off-by: HATAYAMA Daisuke <d.hatayama at fujitsu.com>

Looks good to me.

Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>

Thanks,
Kazu