[Crash-utility] [PATCH] xendump: fix failure to match arm/aarch64 elf format of xendump file

[HAGIO KAZUHITO(萩尾 一仁)]

-----Original Message-----
> 
> 
> 在 2020年10月14日 20:19, lijiang 写道:
> > 在 2020年09月24日 15:41, crash-utility-request at redhat.com 写道:
> >> Message: 3
> >> Date: Thu, 24 Sep 2020 07:41:37 +0000
> >> From: HAGIO KAZUHITO(?????) 	<k-hagio-ab at nec.com>
> >> To: "Discussion list for crash utility usage,	maintenance and
> >> 	development"	<crash-utility at redhat.com>
> >> Cc: Goodbach <goodbach at gmail.com>
> >> Subject: Re: [Crash-utility] [PATCH] xendump: fix failure to match
> >> 	arm/aarch64 elf format of xendump file
> >> Message-ID:
> >> 	<OSBPR01MB1991FE95D0BCF61A8E90AD6DDD390 at OSBPR01MB1991.jpnprd01.prod.outlook.com>
> >>
> >> Content-Type: text/plain; charset="iso-2022-jp"
> >>
> >> -----Original Message-----
> >>> From: Goodbach <goodbach at gmail.com>
> >>> Date: Wed, 12 Aug 2020 11:22:29 +0800
> >>>
> >>> Resolves: https://github.com/crash-utility/crash/pull/61
> >>> Signed-off-by: Goodbach <goodbach at gmail.com>
> >> I'm not sure whether it's needed to also add the ARM one to 32-bit side,
> >
> > There may be needed to add the EM_ARM branch in the if-elf32 block although
> > the scenarios are relatively rare for xen dumU.
> >
> > Anyway, would you mind helping to check this issue? Goodbach.
> >
> Seems the committer has no response yet. But, because the change for this part
> should be good although it may not be a completed patch.
> 
> Acked-by: Lianbo Jiang <lijiang at redhat.com>

Thanks, applied and closed #61.
https://github.com/crash-utility/crash/commit/4d2e607af5d758f9ae42864cb6b26af49e9f5b1d

Kazu


> 
> > Or let's still leave this part to xen engineers?
> >
> > Thanks.
> > Lianbo
> >
> >> but the patch itself looks good to me.
> >>
> >> Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>
> >>
> >> Thanks,
> >> Kazu
> >>
> >>> ---
> >>>  xendump.c | 10 ++++++++++
> >>>  1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/xendump.c b/xendump.c
> >>> index 70cf261..a81817d 100644
> >>> --- a/xendump.c
> >>> +++ b/xendump.c
> >>> @@ -2055,6 +2055,16 @@ xc_core_elf_verify(char *file, char *buf)
> >>>  				goto bailout;
> >>>  			break;
> >>>
> >>> +		case EM_ARM:
> >>> +			if (machine_type_mismatch(file, "ARM", NULL, 0))
> >>> +				goto bailout;
> >>> +			break;
> >>> +
> >>> +		case EM_AARCH64:
> >>> +			if (machine_type_mismatch(file, "ARM64", NULL, 0))
> >>> +				goto bailout;
> >>> +			break;
> >>> +
> >>>  		default:
> >>>  			if (machine_type_mismatch(file, "(unknown)", NULL, 0))
> >>>  				goto bailout;
> >>>
> >>>
> >>> --
> >>> Crash-utility mailing list
> >>> Crash-utility at redhat.com
> >>> https://www.redhat.com/mailman/listinfo/crash-utility
> >>