[Crash-utility] [PATCH] xendump: fix failure to match arm/aarch64 elf format of xendump file

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Thu Sep 24 07:41:37 UTC 2020


-----Original Message-----
> From: Goodbach <goodbach at gmail.com>
> Date: Wed, 12 Aug 2020 11:22:29 +0800
> 
> Resolves: https://github.com/crash-utility/crash/pull/61
> Signed-off-by: Goodbach <goodbach at gmail.com>

I'm not sure whether it's needed to also add the ARM one to 32-bit side,
but the patch itself looks good to me.

Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>

Thanks,
Kazu

> ---
>  xendump.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/xendump.c b/xendump.c
> index 70cf261..a81817d 100644
> --- a/xendump.c
> +++ b/xendump.c
> @@ -2055,6 +2055,16 @@ xc_core_elf_verify(char *file, char *buf)
>  				goto bailout;
>  			break;
> 
> +		case EM_ARM:
> +			if (machine_type_mismatch(file, "ARM", NULL, 0))
> +				goto bailout;
> +			break;
> +
> +		case EM_AARCH64:
> +			if (machine_type_mismatch(file, "ARM64", NULL, 0))
> +				goto bailout;
> +			break;
> +
>  		default:
>  			if (machine_type_mismatch(file, "(unknown)", NULL, 0))
>  				goto bailout;
> 
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility





More information about the Crash-utility mailing list