[Crash-utility] [PATCH 0/2] extensions/trace: Sync up with v5.8 struct renaming

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Fri Sep 25 06:54:34 UTC 2020


-----Original Message-----
> Hi,
> 
> Trying to use the trace extension on a mainline kernel doesn't work, and it
> stems from some struct renaming that has happened upstream.
> 
> These two patches update the internal naming to match the upstream one, and
> includes some backwards-compatibility checks to figure out which naming version
> to use depending on what symbols are available.
> 
> This was briefly tested on on both v5.4 and 5.9-rc1 kernels using QEMU's
> dump-guest-memory. The kernel starts tracing some sched & initicall stuff from
> boot, and "trace show" behaves just fine on both of these.

as far as I've tested, sometimes "trace show" and "trace dump -t" write
less output than "trace-cmd extract" on 5.6 kernels, so there might be
other changes in kernel. 

But anyway, the fixes for the renaming look nicely done.

Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>

Thanks,
Kazu


> 
> Cheers,
> Valentin
> 
> Valentin Schneider (2):
>   extensions/trace: Rename trace_buffer to array_buffer
>   extensions/trace: Rename ring_buffer to trace_buffer
> 
>  extensions/trace.c | 101 ++++++++++++++++++++++++++++-----------------
>  1 file changed, 63 insertions(+), 38 deletions(-)
> 
> --
> 2.27.0
> 
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility





More information about the Crash-utility mailing list