[Crash-utility] [PATCH v2 01/17] Add MIPS64 framework code support

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Wed Apr 21 06:32:03 UTC 2021


-----Original Message-----
>  Hi, Kazu
> 
> 
> On 04/21/2021 02:06 PM, HAGIO KAZUHITO(萩尾 一仁) wrote:
> 
> 
> 	Hi Youling,
> 
> 	sorry for the late reply.
> 
> 	-----Original Message-----
> 
> 		diff --git a/netdump.c b/netdump.c
> 		index f2b3363..d08f3ca 100644
> 		--- a/netdump.c
> 		+++ b/netdump.c
> 		@@ -295,7 +295,7 @@ is_netdump(char *file, ulong source_query)
> 		 			break;
> 
> 		 		case EM_MIPS:
> 		-			if (machine_type_mismatch(file, "MIPS", NULL,
> 		+			if (machine_type_mismatch(file, "MIPS64", NULL,
> 
> 
> 	This change might affect "MIPS" machines, it should be kept.
> 	Does the following work for you?
> 
> 	-                       if (machine_type_mismatch(file, "MIPS", NULL,
> 	+                       if (machine_type_mismatch(file, "MIPS", "MIPS64",
> 
> 	(No need to repost for the present.)
> 
> Thank you for your correction. You are right, and the "MIPS" check should be added here.

OK, with this change and a few corrections that I sent and will fix,
the v2 series looks good to me.

Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>

Thanks,
Kazu





More information about the Crash-utility mailing list