[Crash-utility] [PATCH 14/16] MIPS64: Add the relization of verify symbol

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Wed Mar 10 01:20:24 UTC 2021


-----Original Message-----
> Subject: [PATCH 14/16] MIPS64: Add the relization of verify symbol

nitpicking, "realization" or else?

Thanks,
Kazu

> 
> Add mips64_verify_symbol() implementation, accept or reject a
> symbol from the kernel namelist.
> 
> Signed-off-by: Huacai Chen <chenhuacai at loongson.cn>
> Signed-off-by: Youling Tang <tangyouling at loongson.cn>
> ---
>  mips64.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/mips64.c b/mips64.c
> index 6e8e922..d8a5a0a 100644
> --- a/mips64.c
> +++ b/mips64.c
> @@ -1055,7 +1055,14 @@ mips64_get_elf_notes(void)
>  static int
>  mips64_verify_symbol(const char *name, ulong value, char type)
>  {
> -	return TRUE;
> +	if (CRASHDEBUG(8) && name && strlen(name))
> +		fprintf(fp, "%08lx %s\n", value, name);
> +
> +	if (STREQ(name, "_text") || STREQ(name, "_stext"))
> +		machdep->flags |= KSYMS_START;
> +
> +	return (name && strlen(name) && (machdep->flags & KSYMS_START) &&
> +		!STRNEQ(name, "__func__.") && !STRNEQ(name, "__crc_"));
>  }
> 
>  /*
> --
> 2.1.0





More information about the Crash-utility mailing list