[Crash-utility] [PATCH 07/16] MIPS: Fix display memory size issue

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Fri Mar 12 08:07:02 UTC 2021


-----Original Message-----
> >>>> In the MIPS architecture, no platform uses node_data, only the __node_data
> >>>> symbol. All other architectures use node_data symbols, so it should be
> >>>> feasible to use __mips__ to determine the target (as long as it is a MIPS
> >>>> architecture, use __node_data instead of node_data).
> >>> OK.  Could you add a code comment about this to avoid confusion?
> >> Ok. I will add the following comment, you see if it is feasible.
> > The sgi-ip27 is mips32, isn't it?
> > then please add "the mips32 and mips64 architecutres".
> I will send v2 if possible.

Thanks, it's ok.

Kazu

> 
> --- a/memory.c
> +++ b/memory.c
> @@ -17821,23 +17821,32 @@ next_online_pgdat(int node)
>   {
>           char buf[BUFSIZE];
>          ulong pgdat;
> +/*
> + * "__node_data" is used in the mips32 and mips64 architectures,
> + * and "node_data" is used in other architectures.
> + */
>   #ifndef __mips__
>   #define NODE_DATA_VAR "node_data"
>   #else





More information about the Crash-utility mailing list