[Crash-utility] [PATCH] extensions: remove trace.c and point to the new repository

Bhupesh Sharma bhupesh.sharma at linaro.org
Mon Mar 29 19:39:07 UTC 2021


On Sun, 28 Mar 2021 at 07:18, lijiang <lijiang at redhat.com> wrote:
>
> 在 2021年03月26日 16:51, HAGIO KAZUHITO(萩尾 一仁) 写道:
> > -----Original Message-----
> >> 在 2021年03月26日 12:33, HAGIO KAZUHITO(萩尾 一仁) 写道:
> >>> The trace.c extension module moved to the separate repository:
> >>>   https://github.com/fujitsu/crash-trace
> >>>
> >>> Remove the trace.c file from the crash repository and instead add
> >>> trace.c.README file to point to the new repository for a while.
> >>>
> >>> Signed-off-by: Kazuhito Hagio <k-hagio-ab at nec.com>
> >>> ---
> >>> Lianbo,
> >>> I can see that the spec file of RHEL's crash-trace-command points to
> >>> the tarball in the crash-extensions repository, we can remove trace.c
> >>> in the crash repository?
> >>>
> >> Thank you for the information, Kazu.
> >>
> >> Yes, please go ahead. Hatayama has put the tarball in the github:
> >> https://github.com/fujitsu/crash-trace/archive/v3.0/crash-trace-command-3.0.tar.gz
> >>
> >> We can easily update the URL and Source in the spec file.
> >
> > Thanks for checking this.
> >
> >>
> >>>  extensions/trace.c        | 2592 -------------------------------------
> >>>  extensions/trace.c.README |    7 +
> >>
> >> BTW: It could be good to add a description of the new repository changes in the
> >> top-level README file(at end) instead of a new one. What do you think?
> >
> > hmm, I think that the top-level README file (and README data in help.c) is
> > not very suitable to put a description of an extension module, especially
> > such a temporary information. (I'm going to remove the file someday.)  And
> > this is for users looking for trace.c, when they find there is no trace.c
> > there, will they read the top-level README?  The extensions/trace.c.README
> > will be easier to notice.
> >
> > Do you have any concerns about adding the file?
> >
> As you mentioned above, this is a temporary information(trace.c.README). In the
> future, we may clean up this one, but it is still necessary to tell users where
> they can find the extension modules.
>
> Or is that possible to put the description in the crash Wiki? To be honest, I'm
> not sure about this, but there is no special preference.

I guess putting it in crash wiki makes sense, as a few distros / users
still refer the wiki page in their crash rpm / deb release
documentation.

Thanks,
Bhupesh





More information about the Crash-utility mailing list