[Crash-utility] eppic extension doesn't build with recent master

[Alexander Egorenkov]

Hello,

i'm trying to build the recent master branch of the crash utility and
not able to build eppic extension.

The build failure on x86_64 Fedora 34
-------------------------------------

$ make lzo
[snip]
$ make extensions
gcc -Wall -g -shared -rdynamic -o dminfo.so dminfo.c -fPIC -DX86_64 -DLZO -DGDB_10_2
gcc -Wall -g -shared -rdynamic -o echo.so echo.c -fPIC -DX86_64 -DLZO -DGDB_10_2
Cloning into 'eppic'...
remote: Enumerating objects: 268, done.
remote: Counting objects: 100% (51/51), done.
remote: Compressing objects: 100% (44/44), done.
remote: Total 268 (delta 4), reused 31 (delta 4), pack-reused 217
Receiving objects: 100% (268/268), 256.48 KiB | 2.49 MiB/s, done.
Resolving deltas: 100% (93/93), done.
cd eppic/libeppic && make
bison -peppic -v -t -d eppic.y
eppic.y: warning: 253 shift/reduce conflicts [-Wconflicts-sr]
eppic.y: warning: 20 reduce/reduce conflicts [-Wconflicts-rr]
eppic.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_util.o eppic_util.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_node.o eppic_node.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_var.o eppic_var.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_func.o eppic_func.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_str.o eppic_str.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_op.o eppic_op.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_num.o eppic_num.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_stat.o eppic_stat.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_builtin.o eppic_builtin.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_type.o eppic_type.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_case.o eppic_case.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_api.o eppic_api.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_member.o eppic_member.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_alloc.o eppic_alloc.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_define.o eppic_define.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_input.o eppic_input.c
cc -g -fno-omit-frame-pointer -fPIC   -c -o eppic_print.o eppic_print.c
bison -peppicpp -v -t -d eppicpp.y
eppicpp.y: warning: 23 shift/reduce conflicts [-Wconflicts-sr]
eppicpp.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
cc -g -fno-omit-frame-pointer -fPIC -c eppicpp.tab.c
cc -g -fno-omit-frame-pointer -fPIC -c eppic.tab.c
flex -L -Peppic -t eppic.l > lex.eppic.c
cc -g -fno-omit-frame-pointer -fPIC -c lex.eppic.c
flex -Peppicpp -t eppicpp.l  > lex.eppicpp.c
cc -g -fno-omit-frame-pointer -fPIC -c lex.eppicpp.c
cc -g -fno-omit-frame-pointer -fPIC -o mkbaseop mkbaseop.c
./mkbaseop > baseops.c
cc -g -fno-omit-frame-pointer -fPIC -c baseops.c
ar cur libeppic.a eppic_util.o eppic_node.o eppic_var.o eppic_func.o eppic_str.o eppic_op.o eppic_num.o eppic_stat.o eppic_builtin.o eppic_type.o eppic_case.o eppic_api.o eppic_member.o eppic_alloc.o eppic_define.o eppic_input.o eppic_print.o eppicpp.tab.o eppic.tab.o lex.eppic.o lex.eppicpp.o baseops.o
gcc -g -Ieppic/libeppic -I../gdb-10.2/gdb -I../gdb-10.2/bfd -I../gdb-10.2/include -I../gdb-10.2/gdb/config -I../gdb-10.2/gdb/common -I../gdb-10.2 -nostartfiles -shared -rdynamic -o eppic.so eppic/applications/crash/eppic.c -fPIC -DX86_64 -DGDB_10_2 -Leppic/libeppic -leppic
In file included from ../gdb-10.2/gdb/defs.h:28,
                 from eppic/applications/crash/eppic.c:22:
../gdb-10.2/gdbsupport/common-defs.h:90:10: fatal error: cstdlib: No such file or directory
   90 | #include <cstdlib>
      |          ^~~~~~~~~
compilation terminated.
make[4]: [eppic.mk:67: eppic.so] Error 1 (ignored)
gcc -Wall -g -I. -shared -rdynamic -o snap.so snap.c -fPIC -DX86_64 -DLZO -DGDB_10_2
--------------------------------------------------------------------------------------------------------------


Exactly the same problem is occurring on s390 architecture.

I find it's very weird that a C library like eppic is including a C++
header from GDB.

gdb-10.2/gdbsupport/common-defs.h is a C++ header containing includes of
other C++ headers like cstdlib, array etc. Furthermore, it contains C++
templates !

Has anybody tested this ? Maybe i'm doing something wrong :/
Would appreciate any hint how to fix this. So far i haven't figured out
howto fix this and we depend on eppic extension.


Thanks
Regards
Alex