[dm-devel] Re: [PATCH] dm.c : Check memory allocations

[Jeff Garzik]

On Fri, Dec 27, 2002 at 04:55:31PM -0500, Kevin Corry wrote:
> Check memory allocations when cloning bio's.
> 
> --- linux-2.5.53a/drivers/md/dm.c	Mon Dec 23 23:21:04 2002
> +++ linux-2.5.53b/drivers/md/dm.c	Fri Dec 27 14:50:29 2002
> @@ -394,6 +393,10 @@
>  		 */
>  		clone = clone_bio(bio, ci->sector, ci->idx,
>  				  bio->bi_vcnt - ci->idx, ci->sector_count);
> +		if (!clone) {
> +			dec_pending(ci->io, -ENOMEM);
> +			return;
> +		}
>  		__map_bio(ti, clone, ci->io);
>  		ci->sector_count = 0;
>  
> @@ -417,6 +420,10 @@
>  		}
>  
>  		clone = clone_bio(bio, ci->sector, ci->idx, i - ci->idx, len);
> +		if (!clone) {
> +			dec_pending(ci->io, -ENOMEM);
> +			return;
> +		}
>  		__map_bio(ti, clone, ci->io);
>  
>  		ci->sector += len;


This seems a bit insufficient.  Why is this error not propagated up
through to __split_bio ?

	Jeff