[dm-devel] [PATCH] DM: 2.5.71: dm-ioctl.c: Unregister with devfs before renaming the device

Kevin Corry kevcorry at us.ibm.com
Mon Jun 16 15:57:01 UTC 2003


Unregister the previous name from devfs before renaming the device.

DM originally stored a devfs handle in the hash-cell, and performed the 
unregister based on that handle. These devfs handles have since been removed,
and devices are registered and unregistered simply based on their names. So
the device now needs to be unregistered before we lose the name.

See the following BK change for more details:
http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/md/dm-ioctl.c@1.6?nav=index.html|src/|src/drivers|src/drivers/md|hist/drivers/md/dm-ioctl.c

--- linux-2.5.71a/drivers/md/dm-ioctl.c	16 Jun 2003 18:14:56 -0000
+++ linux-2.5.71b/drivers/md/dm-ioctl.c	16 Jun 2003 20:20:05 -0000
@@ -297,13 +297,14 @@
 	/*
 	 * rename and move the name cell.
 	 */
+	unregister_with_devfs(hc);
+
 	list_del(&hc->name_list);
 	old_name = hc->name;
 	hc->name = new_name;
 	list_add(&hc->name_list, _name_buckets + hash_str(new_name));
 
 	/* rename the device node in devfs */
-	unregister_with_devfs(hc);
 	register_with_devfs(hc);
 
 	up_write(&_hash_lock);


-- 
Kevin Corry
kevcorry at us.ibm.com
http://evms.sourceforge.net/





More information about the dm-devel mailing list