[dm-devel] Re: [PATCH][RFC] dm+syfs
Joe Thornber
thornber at sistina.com
Wed Oct 15 04:33:01 UTC 2003
Mike,
On Tue, Oct 14, 2003 at 06:30:21PM -0700, Mike Christie wrote:
> Currently, a dm device has an entry in /sys/block/dm-* that only
> displays the block layer attributes (queue, iosched and stats). With the
> attached patch (dm_sysfs.patch) the dm's attributes can now also be
> displayed in sysfs. For example, from /sys/block/dm-3 a table with three
> linear targets would look like this:
Good patch. My main problem with it though, is the way it moves the
structs from dm.c, and dm-table.c to dm.h. I really like keeping
implementation seperate from the interfaces. Could you not add a
couple of access functions to get to the information you need ?
- Joe
More information about the dm-devel
mailing list